New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Refactor HTML templates and CSS #2480
Conversation
I haven't taken a look at the actual code yet, but this caught my eye in the cover:
Though this can help, we need to make sure that for anything we're lazily loading in, height/width attributes are properly set ahead of time so that anything loading in doesn't cause the UI to reflow. That might already be the case, but something we should be mindful of because it's very jarring to suddenly have text jump away from you because an image loaded in and pushed content up/down for example. |
Yep yep! I think I've handled all these cases but I'll double check! Edit: Missed one: https://github.com/superseriousbusiness/gotosocial/pull/2480/files#r1432995481 Edit edit: Fixed it! |
Description
Our css and HTML templating was becoming a bit crusty!
This PR does a big hefty refactor, and addresses the following:
Unrelated tweaks that are included in this anyway:
goblin.technology is running with this pull request included, so if you want to see what the HTML / css looks and feels like, go browse!
Here's an example of a single status with these changes:
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.