Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] error extracting status content: no content found #565

Closed
tsmethurst opened this issue May 14, 2022 · 2 comments · Fixed by #598
Closed

[bug] error extracting status content: no content found #565

tsmethurst opened this issue May 14, 2022 · 2 comments · Fixed by #598
Assignees
Labels
bug Something isn't working

Comments

@tsmethurst
Copy link
Contributor

tsmethurst commented May 14, 2022

This occurs sometimes on posts that are just an image and no text:

time=2022-05-13T22:16:51+02:00 level=info msg=ASStatusToStatus: error extracting status content: no content found statusURI=https://mastodon.social/users/yogthos/statuses/108296425480940485

I thought I'd fixed this but apparently not quite!

@tsmethurst tsmethurst added the bug Something isn't working label May 14, 2022
@NyaaaWhatsUpDoc
Copy link
Member

I just realised if you look at the log entry, it's at info level so it's part of that code block that logs the error but doesn't actually stop parsing because of it. I think we might want to update those log messages to be warnings and not look like errors :')

@tsmethurst tsmethurst added this to the v0.3.5 Speedy Sloth milestone May 20, 2022
@tsmethurst
Copy link
Contributor Author

I think in this case we can even just have the ExtractContent function return an empty string and no error if nothing is found; even warnings aren't really necessary if there's just nothing in the status to show I reckon. I'll make a PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants