[bugfix] Fix error extracting status content: no content found
#598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that makes this PR then a prerequisite for #597 ? |
tsmethurst
changed the title
error extracting status content: no content founderror extracting status content: no content found
mmm not sure, i don't think the order really matters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #565 by updating ExtractContent to just return an empty string if no Content is found in an Activity, since this isn't technically an error, it just means that no text content was set and most likely the post contains a poll or media or something. It also updates the extract content function to check if there's an IRI in the content field, because that's a thing that can sometimes happen.