Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Accessibility updates #714

Closed
tsmethurst opened this issue Jul 18, 2022 · 3 comments
Closed

[frontend] Accessibility updates #714

tsmethurst opened this issue Jul 18, 2022 · 3 comments
Labels
accessibility frontend Frontend-related stuff

Comments

@tsmethurst
Copy link
Contributor

Some pointers we should keep in mind when updating our html and css, from @Ryuno-Ki (following things are copy-pasted from fedi messages):


Colors + contrast

Just checked goblin.technology with WAVE, Nu Validator and Orca screenreader.

Looks about perfect.

HTML

Powerful and Dangerous Goblin Tech (GoToSocial semi-public instance).

still contains className (Ctrl-U to check server response)

Plus, there's an in the footer pointing to the git source.

WAVE tool lists several images missing alt attribute (decorative ones have alt="")

Plus, https://html5.validator.nu/?doc=https%3A%2F%2Fgts.superseriousbusiness.org%2F%40gotosocial&showimagereport=yes reports duplicated ID values.

Navigation

Those action icons aren't focusable with keyboard (tabindex="0" missing?).

I miss skip links to jump straight to the timeline:
https://webaim.org/techniques/skipnav/

Screenreaders

Listing to it with Orca screenreader makes me notice, that replies/boosts/favourites just read out the number. There is context missing about what the value is about.

You can utilise a technique such as https://webaim.org/techniques/css/invisiblecontent/ to provide text to screenreaders only.

Thinking about the narrative order (= DOM one) it might make sense to have the date (for toots) read out earlier?

If you turn .toot.expanded into a Flexbox, you can use the order property to push the .info down (but have it appear before .contentgrid in the DOM).

Be aware, that visual order differing from the DOM one is debated in the accessibility community.

@tsmethurst tsmethurst added frontend Frontend-related stuff accessibility labels Jul 18, 2022
@tsmethurst tsmethurst added this to Backlog in Frontend Work Jul 18, 2022
@bremensaki
Copy link

All the project's web views are currently only presented in a light-on-dark theme, which is an accessibility problem I don't see mentioned here.

Is checking a client's prefers-color-scheme setting and switching to suit on the roadmap anywhere?

@tsmethurst
Copy link
Contributor Author

Is checking a client's prefers-color-scheme setting and switching to suit on the roadmap anywhere?

Not yet, I'll make an issue for it

@tsmethurst
Copy link
Contributor Author

I think the points in the original issue have now been addressed, especially since #2480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility frontend Frontend-related stuff
Projects
Development

No branches or pull requests

2 participants