Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fixes + updates in emoji dereferencing logic #1022

Merged
merged 10 commits into from
Nov 11, 2022
Merged

[chore] Fixes + updates in emoji dereferencing logic #1022

merged 10 commits into from
Nov 11, 2022

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Nov 11, 2022 •
edited

  • Rework logging inside emoji dereferencing stuff so we can get a better idea of which emojis are causing problems.
  • Store in-process emoji dereferences inside a locked map in the dereferencer, similar to what we already did for account headers + avatars (why didn't i do this before?? who knows)
  • Fix a wild bug where remote emoji fetching could be triggered over and over by refreshing the web view of a profile.
  • Other small fixes for clarity.

Relates to #916 but who knows if it fixes it or not!

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 6fb4765 into main Nov 11, 2022
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the emoji_poking branch November 11, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc Awaiting requested review from NyaaaWhatsUpDoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsmethurst @NyaaaWhatsUpDoc