[chore] update database caching library #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyaaaWhatsUpDoc
force-pushed
the
update-caching-library-used
branch
2 times, most recently
from
5c6f911
to
33eb0f0
Compare
|
This has been running on |
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
NyaaaWhatsUpDoc
force-pushed
the
update-caching-library-used
branch
from
d79777e
to
8a1bdee
Compare
tsmethurst
reviewed
Nov 15, 2022
Signed-off-by: kim <grufwub@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use
result.Cache{}as the database caching library, which reduces need for boiler plate code, and allows for caching of negative results.The caches themselves will be a bit less performant than previous iterations due to the use of reflection, and having to stringify any generic key type, and internal cache ordering / size limits (a requested feature). But more than made up for by the caching of negative database results, so no need to recheck values of known non-existent keys. And again, configurable size limits!
Configuration of the cache size limits will come at a later date.