Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frogend] Emoji categories #1051

Merged
merged 9 commits into from
Nov 16, 2022
Merged

[frogend] Emoji categories #1051

merged 9 commits into from
Nov 16, 2022

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Nov 15, 2022

drop-down and freeform selection of categories with a new emoji upload
image

@f0x52 f0x52 added the frontend Frontend-related stuff label Nov 15, 2022
Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) few small comments

package.json Outdated Show resolved Hide resolved
web/source/settings/components/combo-box.jsx Outdated Show resolved Hide resolved
Category
<Combobox
state={state}
placeholder="e.g., reactions"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the placeholder :D


"use strict";

const { useComboboxState } = require("ariakit/combobox");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this is very cool :)

@f0x52 f0x52 merged commit aa5c4e0 into main Nov 16, 2022
@f0x52 f0x52 deleted the emoji-categories branch November 16, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend-related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants