Tweak the User-Agent a bit #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the account domain we can pinpoint the source of the request more accurately when looking at the User-Agent header.
|
Is it worth having the github url in it? i just worry it makes the UA a bit too long. |
Ya, I've been pondering about that too. It's getting a little extreme. Lets drop that. |
Based on RFC 7231, our User-Agent header doesn't quite match. It seems to always want Name [/ Version] pairs, with comments in parenthesis and multiple comments separated by a semicolon. Align our UA with that, using application name first by itself in case someone has customised it with the source instance in a comment. Follow that up with gotosocial/<version> and a comment pointing at the source code. This also drops the mention of gofed/activity since a fork is in use.
|
There, that should be better. |
|
@NyaaaWhatsUpDoc I just realised I'm an idiot. We do want to use Host and not the AccountDomain, since Host would be the actual address the server runs on. I have no idea how I read this the wrong way around. [edit] Raise #1156 to revert/fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to tweak the User-Agent a bit to better match my understanding/interpretation of RFC 7231. But in the real world nobody really seems to agree on how these things should be formatted and what they contain so idk if this change is worth it.
This also flips it to use the account domain instead of the host domain, so that when you're looking at the header you can better identify the source of the request.