ap: add support for PKCS1 "RSA PUBLIC KEY" pem block type #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sigrid Solveig Haflínudóttir <sigrid@ftrv.se>
tsmethurst
reviewed
Nov 30, 2022
internal/ap/extract.go
Outdated
| case "RSA PUBLIC KEY": | ||
| p, err = x509.ParsePKCS1PublicKey(block.Bytes) | ||
| default: | ||
| return nil, nil, errors.New("could not decode publicKeyPem to (RSA) PUBLIC KEY pem block type") |
There was a problem hiding this comment.
is it worth logging here what the block type we got was, if block wasn't nil? might be useful for debugging
There was a problem hiding this comment.
@tsmethurst changed it to distinguish between no PEM data vs unknown block type and made it report the type in the latter case.
Signed-off-by: Sigrid Solveig Haflínudóttir <sigrid@ftrv.se>
|
Thank you, this looks great! :) Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sigrid Solveig Haflínudóttir sigrid@ftrv.se