[frogend] Emoji copy "Steal this look" #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0x52
changed the title
|
tested and works on a 0.6.0 instance, I can fetch emoji from my mastodon instance :D |
f0x52
force-pushed
the
frogend-emoji-copy
branch
from
fe83fb0
to
b084dd6
Compare
tsmethurst
approved these changes
Dec 11, 2022
| searchStatus(url); | ||
| } | ||
|
|
||
| return ( |
There was a problem hiding this comment.
is it worth refactoring this into smaller components to avoid all the nesting?
fine if you'd rather not, just checking
| }); | ||
| } | ||
|
|
||
| return ( |
There was a problem hiding this comment.
same comment here re: nesting.. though i guess if we're not going reuse any of these subcomponents elsewhere maybe there's not much point
There was a problem hiding this comment.
I looked over at these again but don't think splitting it into separate components would improve readability too much, and we're not re-using them either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows pasting a remote toot url, which will then present the custom emoji in it for either copying or disabling on the local instance.
Shortcodes can be adapted, and will be validated against already existing local shortcodes.
Not actually tested yet, because the testrig can't fetch remote toots over federation, and already local emoji can't be copied
