Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Enable basic video support (mp4 only) #1274

Merged
merged 3 commits into from
Dec 17, 2022

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request implements video support (mp4) in GtS.

The implementation uses https://github.com/abema/go-mp4 to parse height + width of mp4 videos, and then generates a solid-color thumbnail for the video using those dimensions.

It's basically just an adaptation of #1165 so credit goes almost entirely to @theSuess !! I only adapted it so I could tidy it up a bit, fix some tests, and remove the ffmpeg option to focus solely on the basic go implementation.

closes #1089

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 2bbc64b into main Dec 17, 2022
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the theSuess-video-support branch December 17, 2022 04:38
@tsmethurst tsmethurst mentioned this pull request Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Video Support
3 participants