Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] return early in websocket upgrade handler #1315

Merged
merged 3 commits into from
Jan 8, 2023
Merged

[bugfix] return early in websocket upgrade handler #1315

merged 3 commits into from
Jan 8, 2023

Commits on Jan 6, 2023

  1. launch websocket streaming in goroutine to allow upgrade handler to r… 

    …eturn

Signed-off-by: kim <grufwub@gmail.com>
    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    3da666e View commit details
    Browse the repository at this point in the history

  2. don't send any message on ping, improved close check on failed read 

    Signed-off-by: kim <grufwub@gmail.com>
    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    ea046f3 View commit details
    Browse the repository at this point in the history

  3. use context to signal wsconn close, ensure canceled in read goroutine 

    Signed-off-by: kim <grufwub@gmail.com>
    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    df900cc View commit details
    Browse the repository at this point in the history