Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Email notifications for new / closed moderation reports #1628

Merged
merged 7 commits into from
Mar 19, 2023

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request implements email notifications for:

  • all instance admins+moderators when a new report is created
  • creator of the report (local account only) when their report is closed

I used the gts account to ask folks whether they would want emails to multiple admins to be Bcc'd or To'd, and the results were quite mixed. Some people prefer anonymous notifications, and some people suggested it would be nice to be able to use reply-all to discuss reports with other admins. To serve both those needs, there's now a config flag smtp-disclose-recipients which, when enabled, puts all admins + moderators in To instead of Bcc.

Examples:

direct email To:

Screenshot from 2023-03-15 13-57-48

Email to Undisclosed Recipients:

Screenshot from 2023-03-15 14-33-32

Email to a user when their report has been closed by a moderator:

01CEB1MARPHW3HSJCVDY7MZFPC

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst merged commit 7db81cd into main Mar 19, 2023
@tsmethurst tsmethurst deleted the report_email_admin branch March 19, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants