Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix relationship not updating 'following' on accept follow request #1658

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

We introduced a small issue where the follow cache wasn't being invalidated when a follow request was accepted, leading to a case where you could follow someone, have them accept, and still have your relationship show that you aren't following them.

This PR fixes this by just invalidating the follow cache when a follow request is accepted.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

instead of manually invalidating follow as you have added in the accept function, I would instead just make sure it is invalidated in the follow request invalidate hook (in the caches package). also vice versa

@tsmethurst
Copy link
Contributor Author

Ahhh okay no problem, just a sec...

@tsmethurst tsmethurst reopened this Mar 31, 2023
@tsmethurst
Copy link
Contributor Author

Accidentally closed + reopened the PR, don't mind me :')

@NyaaaWhatsUpDoc
Copy link
Member

nice catch 👌

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 344c7e5 into main Mar 31, 2023
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the relationship_fix branch March 31, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants