Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix link to remote emoji pgae #1845

Merged
merged 5 commits into from
May 31, 2023

Conversation

moan0s
Copy link
Contributor

@moan0s moan0s commented May 29, 2023

Description

The pull request fixes the link from the local custom emoji page to the remote custom emoji page

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

just announced it there

  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.
    -> lot of errors with golangci-lint run but none of them seem to be my fault

@moan0s moan0s marked this pull request as ready for review May 29, 2023 10:49
@tsmethurst
Copy link
Contributor

Thanks!

@tsmethurst tsmethurst merged commit 70262d4 into superseriousbusiness:main May 31, 2023
2 checks passed
tsmethurst pushed a commit that referenced this pull request Jun 14, 2023
* Replace pinafore with semaphore

* Typo

* Fix remote emoji link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants