Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Try to fix the webfinger test, again #1931

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[bugfix] Try to fix the webfinger test, again #1931

merged 1 commit into from
Jun 27, 2023

Commits on Jun 27, 2023

  1. [bugfix] Try to fix the webfinger test, again 

    For some reason we hit the case in CI where the
TestFingerWithHostMetaCacheStrategy seems to experience some time
dilation. It's possible this is a genuine bug, but I can't for the life
of me reproduce it locally, even after having run this test thousands of
times (-count=1000 when invoking go test etc.)

This changes the test to explicitly stop the webfinger cache, set TTL
and Sweep frequency to something well beyond the lifetime of the cache
during the test and then starts the cache again. Hopefully that does it,
because the other option that remains is that for some reason
timekeeping in CI/Docker is not as precise as when running the test on a
host.
    @daenney
    daenney committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    fb4cecb View commit details
    Browse the repository at this point in the history