Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Reorder web view logic, other small fixes #1954

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Jul 7, 2023

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request updates some of our web view status / account stuff:

  • Reorder web view auth logic so that if an AP request comes in on a status URL, the AP representation can be served properly even if it's not a public status (assuming requester has permission to view it). Previously, we only served AP representations of public statuses that were requested using the URL rather than the AP URI, but this is not quite right.
  • Serve 404 for local accounts that have been suspended, instead of showing a web view of an empty profile.
  • Comment and tidy up for readability.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst merged commit ac564c1 into main Jul 7, 2023
3 checks passed
@tsmethurst tsmethurst deleted the webview_tweaks branch July 7, 2023 12:58
@huabin
Copy link

huabin commented Jul 8, 2023

  • Serve 404 for local accounts that have been suspended, instead of showing a web view of an empty profile.

It doesn't seem to work, it is still showing an empty profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants