Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Use generic pointer function #2080

Merged
merged 1 commit into from Aug 7, 2023
Merged

[chore] Use generic pointer function #2080

merged 1 commit into from Aug 7, 2023

Conversation

daenney
Copy link
Member

@daenney daenney commented Aug 7, 2023

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This replaces the different $TypePtr functions with a generic implementation. I would've kept it in testrig, but it turns out we have some stray trueBool and falseBool functions outside of tests too. So I opted for util instead.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

This replaces the different $TypePtr functions with a generic
implementation.
Bitrate: Uint64Ptr(1206522),
Duration: util.Ptr[float32](15.033334),
Framerate: util.Ptr[float32](30.0),
Bitrate: util.Ptr[uint64](1206522),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the only ones where Go can't quite infer the right type, it considers them as float64 and int instead. It should be able to with some improvements in 1.21 I think.

@daenney
Copy link
Member Author

daenney commented Aug 7, 2023

It's a minor cleanup, but it does have the advantage that in some places we no longer pull the testrig package in for tests, as they were only accessing the TrueBool/FalseBool functions.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit be3718f into main Aug 7, 2023
3 checks passed
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the generic-ptr branch August 7, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants