New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Initial metrics #2334
[feature] Initial metrics #2334
Conversation
I don't really know if its possible to add tests for this |
Thanks for this! Finishing off a couple things now, will try to have a look and review soon! |
c029932
to
68f3983
Compare
7de1c39
to
b8b83be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that looks good. This gives us a good starting point and we can start to add custom metrics for things later on. Thanks for the work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I'll just rebase this on main (if I can) to see if I can fix the merge conflicts...
baa4d38
to
56c0bad
Compare
Description
Relating to #1218, this PR implements the following metrics:
These are instrumented via OpenTelemetry.
Following settings are added:
Turning metrics on exposes them on a public
/metrics
endpoint for Prometheus pull.The code has largely been modeled after #1623
Checklist
go fmt ./...
andgolangci-lint run
.