Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore/bugfix/horror] Allow expires_in and poll choices to be parsed from strings #2346

Merged
merged 3 commits into from Nov 10, 2023

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

Unfortunately, some of our fave clients (pinafore, semaphore, derivatives thereof) submit some poll-related fields as strings when they ought to be integers. These clients aren't maintained anymore, so submitting fixes upstream is not useful. This hack allows those strings to work as well. This is technically compliant with the Mastodon API, though the Mastodon API is not documented as allowing this.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst marked this pull request as draft November 9, 2023 17:24
@tsmethurst tsmethurst marked this pull request as ready for review November 10, 2023 12:40
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit c7ecab9 into main Nov 10, 2023
3 checks passed
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the poll_string_fixes branch November 10, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants