Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] support endless polls, and misskey's' method of inferring expiry in closed polls #2349

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

As the title says really. Misskey doesn't always set the endTime AS property, both in the case of an endless poll (where closed is also unset), or in the case that an expiring poll is now closed and it uses the set closed property to infer the past expiry. As such there's a required database migration in order to support empty endTime property.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc force-pushed the bugfix/more-permissive-as-question-parsing branch from 81ff518 to 995bb85 Compare November 11, 2023 10:05
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit deaea10 into superseriousbusiness:main Nov 11, 2023
2 checks passed
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the bugfix/more-permissive-as-question-parsing branch November 11, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants