Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] self-referencing collection pages for status replies #2364

Merged
merged 17 commits into from Nov 20, 2023
Merged

[bugfix] self-referencing collection pages for status replies #2364

merged 17 commits into from Nov 20, 2023

Commits on Nov 17, 2023

  1. update GetStatusReplies() to use paging, update StatusRepliesGet() to… 

    … use new paging code
    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9070f85 View commit details
    Browse the repository at this point in the history

  2. fix call to non-existent function

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f60853d View commit details
    Browse the repository at this point in the history

  3. add compatibility fix so 'page=true' enables paging

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    415866d View commit details
    Browse the repository at this point in the history

  4. update visibility package to use gtserror.Newf() instead of fmt.Errorf()

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6202072 View commit details
    Browse the repository at this point in the history

  5. more accurately abide by mastodon's very strange replies endpoint ...

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    4ff30d4 View commit details
    Browse the repository at this point in the history

  6. improved code commenting re: paging semantics for fedi endpoints

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    af20a2d View commit details
    Browse the repository at this point in the history

  7. use correct collection ID ... 🤦

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d5f71fe View commit details
    Browse the repository at this point in the history

  8. check for zero length slices before getting page ID values

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    07e9f5c View commit details
    Browse the repository at this point in the history

  9. a comment

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    65fe598 View commit details
    Browse the repository at this point in the history

  10. improved comment to explain Mastodon's behaviour for replies endpoint

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    74e2e75 View commit details
    Browse the repository at this point in the history

  11. fix 'first' collection page property usage. ensure totalItems is used… 

    … compatibly in /replies endpoint
    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    691d8a6 View commit details
    Browse the repository at this point in the history

  12. update /replies endpoint to use more AP compliant logic, and less hac… 

    …ky ...
    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    073e6d9 View commit details
    Browse the repository at this point in the history

  13. improve requester + receiver related account terminology

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    209c93e View commit details
    Browse the repository at this point in the history

  14. update tests

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    675185c View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. move 'onlyOtherAccounts' query parsing to apiutil package

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    26d90e6 View commit details
    Browse the repository at this point in the history

  2. use accepted 'content-type' determined during earlier negotiation

    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    462e342 View commit details
    Browse the repository at this point in the history

  3. rename 'GetStatusChildren()' test to 'GetStatusChildren()' and add ne… 

    …w 'GetStatusChildren()' test
    @NyaaaWhatsUpDoc
    NyaaaWhatsUpDoc committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e37ca7c View commit details
    Browse the repository at this point in the history