Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Federate status language in and out #2366

Merged
merged 13 commits into from Nov 21, 2023
Merged

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request implements contentMap handling to append language to outgoing statuses, and parse language from incoming statuses (see the new docs entry for how this is done exactly).

Since go-fed handles contentMap and content a bit funkily, some new normalization logic has also been added to ensure that content and contentMap are appended separately to outgoing statuses, and to ensure that they're parsed separately and then recombined on incoming statuses.

Also added some tests, and made a few consistency fixups on the normalization / serialization functions in the ap package.

closes #1277

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

Just a few comments remaining! Otherwise this is looking really good 👀

@tsmethurst tsmethurst merged commit cfefbc0 into main Nov 21, 2023
3 checks passed
@tsmethurst tsmethurst deleted the contantMap_handling branch November 21, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Federate language of Notes etc in and out of GtS properly
2 participants