Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance/postgres] Rename constraints, remove duplicate indexes #2392

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Nov 28, 2023

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This PR drops a lot of duplicate indexes in cases where:

  • a unique constraint for columns in the index already exists (so this index is a duplicate); OR --
  • a covering index already exists for the indexed column

The PR also renames constraints that were misnamed in previous migrations (Postgres only).

closes #2122
closes #2017

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

Copy link
Member

@daenney daenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks fair, as long as we're sure about the indexes we're dropping.

For posterity: relational databases automatically create indexes for the primary key as well as any column with a unique constraint. We just so happened to also be creating those indexes, duplicating a bunch of work, paying the cost for updating two indexes instead of one and using some extra space for no good reason.

@tsmethurst tsmethurst merged commit 6abe91c into main Nov 29, 2023
2 checks passed
@tsmethurst tsmethurst deleted the remove_duplicate_indices branch November 29, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug?] maybe duplicate DB indicēs [chore/performance] Clean up unused/duplicate indexes for Postgres
2 participants