Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Parse instance descriptors as markdown, show T&C on /about #2481

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request updates our settings panel to allow parsing instance descriptor fields as markdown (short description, description, terms and conditions), presenting the original "unparsed" version of the field to the user for editing, similar to what we do for status text and account note/bio.

Also updates the /about page to add a table of contents (since it's getting long), and expose terms and conditions.

Few little other nice changes:

Closes #143
Closes #707

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

only a single comment, otherwise looks good :)

@tsmethurst tsmethurst merged commit d5e3996 into main Jan 5, 2024
3 checks passed
@tsmethurst tsmethurst deleted the instance_description_updates branch January 5, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants