Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Account alias / move API + db models #2518

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Jan 13, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request adds client API support and documentation for setting account aliases ("alsoKnownAs") and triggering the account Move activity.

  • add POST to /api/v1/account/alias to set/unset aliases.
  • add POST to /api/v1/account/move to trigger a move to target account.
  • update database models and support functions to set/unset/retrieve aka and move URIs properly
  • update internal-to-frontend conversion logic to include moved and aka URIs information

Currently while it is possible to send a Move activity to the clientAPI processor via the newly-added endpoints, assuming all preconditions are met, nothing is yet processed. This will come in a subsequent PR.

relates to #130

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

have left a few comments here and there but otherwise looks good to me! :)

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit c36f9ac into main Jan 16, 2024
3 checks passed
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the aka_and_moved_to_client_API branch January 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants