Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Downgrade OTEL libraries to 1.20 #2546

Merged
merged 1 commit into from
Jan 21, 2024
Merged

[bugfix] Downgrade OTEL libraries to 1.20 #2546

merged 1 commit into from
Jan 21, 2024

Conversation

daenney
Copy link
Member

@daenney daenney commented Jan 20, 2024

Description

For some reason httpconv seems to have disappeared from 1.21, which results in a 1.21 runtime with 1.20 semconv/httpconv which seems to break some things.

For now, this rolls the OTEL dependencies back to 1.20 which should fix the observability issues. We'll need to take a look at how to upgrade safely and correctly in the future.

Relates to #2503.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

For some reason httpconv seems to have disappeared from 1.21, which
results in a 1.21 runtime with 1.20 semconv/httpconv which seems to
break some things.

For now, this rolls the OTEL dependencies back to 1.20 which should fix
the observability issues. We'll need to take a look at how to upgrade
safely and correctly in the future.

Relates to #2503.
@tsmethurst
Copy link
Contributor

Nice one :)

@tsmethurst tsmethurst linked an issue Jan 21, 2024 that may be closed by this pull request
@tsmethurst tsmethurst merged commit 74380ae into main Jan 21, 2024
3 checks passed
@tsmethurst tsmethurst deleted the otel-120 branch January 21, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] OpenTelemetry Tracing resource merge error
2 participants