Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Disable the test for long syslog messages over Unix datagram sockets on macOS #2700

Conversation

VyrCossont
Copy link
Contributor

Description

This pull request disables the test for long syslog messages over Unix datagram sockets on macOS, where it's known to hang the test runner. I suspect this is an implementation limit for macOS sockets. Given #493, which seems to cap the message size, I'm not sure this is an issue anything's going to hit in production. Also, we don't support macOS for production deployments anyway.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst
Copy link
Contributor

Thanks :)

@tsmethurst tsmethurst merged commit c2a691f into superseriousbusiness:main Feb 29, 2024
2 checks passed
@VyrCossont VyrCossont deleted the macos-disable-long-syslog-dgram-test branch February 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants