[security] Check all involved IRIs during block checking #593
Conversation
internal/db/bundb/account.go
Outdated
| return cached.ID, nil | ||
| } | ||
|
|
||
| account := >smodel.Account{} |
There was a problem hiding this comment.
Is it worth doing this separate db query? Because in the case this account isn't cached the result will never be cached, increasing database access. Alternatively it would be just doing a.GetAccountByURI(...) and returning the ID from that
There was a problem hiding this comment.
Yeah I also wasn't sure about these. The problem is that we really just need that one field, whereas a full-blown GetAccountByURI does a massive join with all the relations we have set on it. So this is a really cheap query, but it will indeed mean more queries in total. I'm not really sure which way ends up faster overall
There was a problem hiding this comment.
Replaced with cacheable functions 👍
internal/db/bundb/status.go
Outdated
| return cached.AccountID, nil | ||
| } | ||
|
|
||
| status := >smodel.Status{} |
There was a problem hiding this comment.
Same as above, but using relevant status function
There was a problem hiding this comment.
Replaced with cacheable functions 👍
This PR updates the logic in the Blocked function of the federator to make more aggressive checks against accounts involved in the Activity in some way.
In short, we now make sure that:
This means that in the following scenario --
-- the request will be refused because our instance knows that local2 blocks remote. So even though local1 technically can see the status, the instance won't process it because of the block. This makes it much less likely that local2 will bump into the status somehow, and see a message from someone who they blocked.
The PR also tightens up some of the domain block logic in the same way. Now, if an Activity is To'd, CC'ed, or RepliedTo someone from a blocked domain, the request will be refused, even if the inbox account follows the account who created the Activity.
In order to make these extra checks work without totally tanking the database doing lots of selects, some new lighter database functions have been added to select just the account ID of an account or status by its URI.