Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packaging] Packaging updates #655

Merged
merged 3 commits into from
Jun 19, 2022
Merged

[packaging] Packaging updates #655

merged 3 commits into from
Jun 19, 2022

Conversation

tsmethurst
Copy link
Contributor

This PR updates some of our packaging in the following ways:

  1. Bump version of golang to 1.18.3.
  2. Bump gotosocial-drone-build to 0.0.5 (which includes bumps to GoReleaser and Docker buildx).
  3. Remove the bundled source tarball from releases, since it was misleading and unhelpful.
  4. Add a release archive that just contains the bundled web/assets and web/templates folders, to make life easier for people doing ports.

Should close #654

However, it doesn't really address the 'tarbomb' point raised in that issue, because while you can instruct goreleaser to embed a root directory inside a tar, it would cause our installation instructions to change, and people would have to run different installation commands for different releases. This is not something that I like the idea of doing, so I left it out of this PR. However, if there's enough impetus and interest in changing this, we can still do this in another PR.

@tsmethurst tsmethurst merged commit f42d5d8 into main Jun 19, 2022
@tsmethurst tsmethurst deleted the goreleaser_updates branch June 19, 2022 14:44
@igalic
Copy link
Contributor

igalic commented Jun 19, 2022

does this build the assets, too?

@tsmethurst
Copy link
Contributor Author

does this build the assets, too?

Yes :) essentially it replaces that weird source tarball with a tar that just contains web/assets/dist and web/assets/template (so everything in the web/assets/ dir aside from the source dir). So when porting you can clone the latest tag, grab the compiled assets tar and untar it, then do whatever you need to do without having to install node/yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Release artefact doesn't contain built assets
2 participants