[bugfix] Make /api/v2/media more compatible with masto API
#724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmethurst
force-pushed
the
api_v2_media_nullable_fields
branch
from
1a6ec8b
to
4c5cd9e
Compare
|
Will this fix POST to /api/v2/media timing out in Pinafore? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the api model for a media attachment a little bit, to make some fields return null instead of empty strings.
In addition, it implements a workaround which nulls the URL field returned by
/api/v2/media, in keeping with the mastodon API, which expects callers to just use the returned ID and preview URL rather than having the actual URL filled in already.