[bugfix] Fix Toot CLI media attachments not working properly #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of the Toot cli not attaching media correctly to new statuses.
The problem was that when it comes to POST form data, the Mastodon API expects clients to use the key
media_ids[]for their list of media attachment IDs. However, GtS was just acceptingmedia_ids, which works great for json, but not so much for clients that use POST forms like Toot does.This PR implements a simple fix for this by parsing
media_ids[]in forms, but still usingmedia_idsfor json and xml. Tested and working with Toot, and therefore should work for other mastodon clients as well.closes #686