Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update bun / sqlite versions; update gtsmodels #754

Merged
merged 17 commits into from
Aug 15, 2022

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Aug 13, 2022

This PR upsteps our bun and sqlite dependencies to the latest versions.

In order to make this work, bool values on many database models had to be changed from bool to *bool, due to a change in bun.

The PR also adds some logic into the database to update db entries more selectively when using UpdateByID -- callers can now pass in the specific columns they wish to update.

For reviewers:

  • These are the commits where bools are changed to bool pointers: 672b313 93db2ad (arguably the most crucial part of the PR)
  • Everything in the vendor subdirectories doesn't need to be reviewed, it's just updating dependencies.

Closes #486

Deployed this on both gts.superseriousbusiness.org and goblin.technology (docker/postgres and binary/sqlite respectively) and it seems stable so far.

@tsmethurst tsmethurst marked this pull request as ready for review August 13, 2022 16:36
@tsmethurst tsmethurst marked this pull request as draft August 13, 2022 16:46
@tsmethurst tsmethurst marked this pull request as ready for review August 14, 2022 09:44
@NyaaaWhatsUpDoc
Copy link
Member

Deployed this on both gts.superseriousbusiness.org and goblin.technology (docker/postgres and binary/sqlite respectively) and it seems stable so far.

Just to double check, have you grepped your logs for any nil-ptr related panics?

@tsmethurst
Copy link
Contributor Author

Just to double check, have you grepped your logs for any nil-ptr related panics?

Yeah :) Only one cropped up, which led to 7ab8181, and since then I haven't seen any more

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit ac6ed3d into main Aug 15, 2022
@NyaaaWhatsUpDoc NyaaaWhatsUpDoc deleted the bump_the_bun_gently branch August 15, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] Tidy up Bun annotations to allow upstep to bun v1.1.4
2 participants