-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Update bun / sqlite versions; update gtsmodels #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes attachment, status, account, user
Just to double check, have you grepped your logs for any nil-ptr related panics? |
Yeah :) Only one cropped up, which led to 7ab8181, and since then I haven't seen any more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upsteps our bun and sqlite dependencies to the latest versions.
In order to make this work,
bool
values on many database models had to be changed frombool
to*bool
, due to a change in bun.The PR also adds some logic into the database to update db entries more selectively when using
UpdateByID
-- callers can now pass in the specific columns they wish to update.For reviewers:
vendor
subdirectories doesn't need to be reviewed, it's just updating dependencies.Closes #486
Deployed this on both gts.superseriousbusiness.org and goblin.technology (docker/postgres and binary/sqlite respectively) and it seems stable so far.