[frontend] Unified panels #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0x52
added
frontend
f0x52
force-pushed
the
unified-panels
branch
2 times, most recently
from
2c4c279
to
ecbf950
Compare
f0x52
force-pushed
the
unified-panels
branch
from
0edf3e6
to
7cebb50
Compare
tsmethurst
reviewed
Sep 20, 2022
There was a problem hiding this comment.
Overall this looks great and it's a big step up from what we had before :)
Just some comments about style, and some comments about commented-out code that perhaps should be deleted -- I may have been too zealous here though, because I saw you also put code in that we can just uncomment out later when more features are implemented, so take my recommendations here with a pinch of salt!
Love the experience of the emoji upload page, that's absolutely brilliant <3
Oh yeah, also please check through for console.log calls and make sure you're not logging things unnecessarily -- when running this locally i see quite a few logs in the console that you probably put in there for debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworking the currently separate user and admin settings panels into a consistent whole. Hopefully fix some other papercuts with them along the way as well.
very work in progress
