[performance] cache domains after max retries in transport #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmethurst
approved these changes
Oct 5, 2022
| @@ -102,13 +110,13 @@ func (c *controller) NewTransport(pubKeyID string, privkey *rsa.PrivateKey) (Tra | |||
| } | |||
|
|
|||
| // Cache this transport under pubkey | |||
| if !c.cache.Put(pubStr, transp) { | |||
| if !c.trspCache.Put(pubStr, transp) { | |||
There was a problem hiding this comment.
Can you remind me under what conditions Put would return false?
| // domain resolution type errors, so this cached result | ||
| // indicates this server is likely having issues. | ||
| if t.controller.badHosts.Has(host) { | ||
| return nil, errors.New("too many failed attempts") |
There was a problem hiding this comment.
is it worth making an error type for this so we can check for it? or nah?
| // errors that are retried upon are server failure and | ||
| // domain resolution type errors, so this cached result | ||
| // indicates this server is likely having issues. | ||
| if t.controller.badHosts.Has(host) { |
There was a problem hiding this comment.
The Has call doesn't reset the ttl i assume?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max retries are only reached if on HTTP server, DNS resolution or connection type errors. By caching these hostname failures we don't clog up the outoging request queue with likely failing requests.