Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to show instead of landing page on / #922

Merged
merged 12 commits into from
Nov 3, 2022

Conversation

i5heu
Copy link
Contributor

@i5heu i5heu commented Oct 25, 2022

No description provided.

Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool PR :)

You'll have to fiddle with test/cliparsing.sh and test/envparsing.sh to get it passing tests. Basically you just gotta add the new parameters to the expected output there. Let me know if you need any help with it :)

internal/web/profile.go Outdated Show resolved Hide resolved
internal/web/web.go Outdated Show resolved Hide resolved
internal/web/web.go Outdated Show resolved Hide resolved
@tsmethurst
Copy link
Contributor

Heya, sorry for responding slowly again. I'm only just getting back to GtS properly now after time away and then being ill. I added just one more review comment :) After that this should be good to go

@i5heu
Copy link
Contributor Author

i5heu commented Oct 29, 2022

Heya, sorry for responding slowly again. I'm only just getting back to GtS properly now after time away and then being ill. I added just one more review comment :) After that this should be good to go

Take your time!

internal/web/web.go Outdated Show resolved Hide resolved
internal/web/profile.go Outdated Show resolved Hide resolved
@tsmethurst
Copy link
Contributor

Looks good now! Thank you for this, and for making the changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants