Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Wrap media in read closer #941

Merged
merged 5 commits into from
Nov 3, 2022
Merged

[bugfix] Wrap media in read closer #941

merged 5 commits into from
Nov 3, 2022

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Nov 1, 2022 •
edited

  • User ReadClosers instead of Readers where possible.
  • Rejig close deferrals in some places.

May partially address #916

@NyaaaWhatsUpDoc
Copy link
Member

A singular comment, though relating to code not a part of this PR technically (though related). Otherwise ready to go :)

@tsmethurst tsmethurst merged commit 1dfa7fe into main Nov 3, 2022
@tsmethurst tsmethurst deleted the wrap_media_in_read_closer branch November 3, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc NyaaaWhatsUpDoc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsmethurst @NyaaaWhatsUpDoc