Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Custom Emoji Deletion #994

Merged
merged 13 commits into from
Nov 8, 2022
Merged

[frontend] Custom Emoji Deletion #994

merged 13 commits into from
Nov 8, 2022

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Nov 7, 2022 •
edited

also taking the time to refactor that part of the code to use RTK Query

also fixes #945

@f0x52 f0x52 added frontend Frontend-related stuff frontend-api Backend requirement for Frontend stuff labels Nov 7, 2022
@f0x52 f0x52 requested a review from tsmethurst November 7, 2022 19:53
tsmethurst
tsmethurst reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, a few little comments but nothing too important :) if you're happy with it, merge it and we can iron out creases later imo

web/source/settings/admin/emoji/new-emoji.js Outdated Show resolved Hide resolved
web/source/settings/components/form/index.js Show resolved Hide resolved
web/source/settings/lib/api/index.js Show resolved Hide resolved
web/source/settings/lib/get-views.js Show resolved Hide resolved
@f0x52 f0x52 mentioned this pull request Nov 8, 2022
Merged
@f0x52 f0x52 merged commit eb25739 into main Nov 8, 2022
@f0x52 f0x52 deleted the settings-custom-emoji branch November 8, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmethurst tsmethurst tsmethurst left review comments

Assignees
No one assigned
Labels
frontend Frontend-related stuff frontend-api Backend requirement for Frontend stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug/chore] /api/v1/admin/custom_emojis/{id} does not exist yet
2 participants
@f0x52 @tsmethurst