[feature] various worker / request queue improvements #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NyaaaWhatsUpDoc
commented
Nov 7, 2022
NyaaaWhatsUpDoc
commented
- greatly simplifies request queue to remove per-method queues
- uses faster lock-free map implementation for per-host queues
- reduces number of allocations by only allocating new channel if existing not found
- adds warning logs if worker / request queues are full
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
NyaaaWhatsUpDoc
added
enhancement
NyaaaWhatsUpDoc
changed the title
Signed-off-by: kim <grufwub@gmail.com>
tsmethurst
approved these changes
Nov 8, 2022
| } | ||
|
|
||
| if cfg.MaxBodySize <= 0 { | ||
| // By default set this to a reasonable 40MB | ||
| cfg.MaxBodySize = 40 * 1024 * 1024 | ||
| cfg.MaxBodySize = int64(40 * bytesize.MiB) |
| } | ||
|
|
||
| // Allocate a new host queue (or return a sneaky existing one). | ||
| queue, _ = c.queue.GetOrInsert(host, make(chan struct{}, c.cmax)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.