fix(station): corrected SDk to SDK (#255)

* fix(station): corrected SDk to SDK * created constant to store invalid message header error
superstreamlabs · Aug 10, 2022 · 5a73666 · 5a73666
1 parent 616de47
commit 5a73666
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/handlers/poison_messages.go b/handlers/poison_messages.go
@@ -31,6 +31,8 @@ import (
 
 type PoisonMessagesHandler struct{}
 
+const invalidPoisonHeaderErrMessage string = "Missing mandatory message headers, please upgrade the SDK version you are using"
+
 func (pmh PoisonMessagesHandler) HandleNewMessage(msg *nats.Msg) {
 	var message map[string]interface{}
 	err := json.Unmarshal(msg.Data, &message)
@@ -54,7 +56,7 @@ func (pmh PoisonMessagesHandler) HandleNewMessage(msg *nats.Msg) {
 	producedByHeader := poisonMessageContent.Header.Get("producedBy")
 
 	if connectionIdHeader == "" || producedByHeader == "" {
-		logger.Error("Error while getting notified about a poison message: Missing mandatory message headers, please upgrade the SDk version you are using")
+		logger.Error("Error while getting notified about a poison message: " + invalidPoisonHeaderErrMessage)
 		return
 	}
 

diff --git a/handlers/stations.go b/handlers/stations.go
@@ -595,8 +595,8 @@ func (sh StationsHandler) GetMessageDetails(c *gin.Context) {
 	producedByHeader := natsMsg.Header.Get("producedBy")
 
 	if connectionIdHeader == "" || producedByHeader == "" {
-		logger.Error("Error while getting notified about a poison message: Missing mandatory message headers, please upgrade the SDk version you are using")
-		c.AbortWithStatusJSON(configuration.SHOWABLE_ERROR_STATUS_CODE, gin.H{"message": "Error while getting notified about a poison message: Missing mandatory message headers, please upgrade the SDk version you are using"})
+		logger.Error("Error while getting notified about a poison message: " + invalidPoisonHeaderErrMessage)
+		c.AbortWithStatusJSON(configuration.SHOWABLE_ERROR_STATUS_CODE, gin.H{"message": "Error while getting notified about a poison message: " + invalidPoisonHeaderErrMessage})
 		return
 	}