RND-130-align-the-broker-with-nats-v-2-10-7 #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-davidd
requested review from
idanasulin2706,
avrhamNeeman and
shay23b
as code owners
idanasulin2706
approved these changes
Dec 24, 2023
server/const.go
Outdated
| @@ -41,7 +41,7 @@ var ( | |||
|
|
|||
| const ( | |||
| // VERSION is the current version for the memphis server. | |||
| VERSION = "1.4.1" // ** changed by Memphis | |||
| VERSION = "1.3.1" // ** changed by Memphis | |||
There was a problem hiding this comment.
1.4.1, this is a mistake in the cloud. it should be 1.4.1 in the cloud as well so fix it over there as well
| } | ||
|
|
||
| // ** added by memphis | ||
| func newFileStoreWithCreatedMemphis(fcfg FileStoreConfig, cfg StreamConfig, created time.Time, prf keyGen, account *Account) (*fileStore, error) { | ||
| func newFileStoreWithCreatedMemphis(fcfg FileStoreConfig, cfg StreamConfig, created time.Time, prf, oldprf keyGen, account *Account) (*fileStore, error) { |
There was a problem hiding this comment.
the implementation of this function should exactly the same as newFileStoreWithCreated, besides the extra account field.
Make sure it is the same in mem store as well
shay23b
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.