Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with long named tags getting cut off in station view #956

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Fix issue with long named tags getting cut off in station view #956

merged 1 commit into from
Jun 7, 2023

Conversation

akarsh-jain-790
Copy link
Contributor

@akarsh-jain-790 akarsh-jain-790 commented Jun 1, 2023 •
edited
Loading

Fixes: #939

Screenshot 2023-06-01 at 6 56 38 PM

@akarsh-jain-790 akarsh-jain-790 marked this pull request as ready for review June 1, 2023 13:27
@yanivbh1
Copy link
Contributor

yanivbh1 commented Jun 4, 2023

Thank you, @akarsh-jain-790 .
@avrhamNeeman FYI.

@avrhamNeeman
Copy link
Contributor

@akarsh-jain-790 Thank you!
As I checked, this fixed the issue but caused the columns to be misaligned. Could you please add the fix for this?

@akarsh-jain-790
Copy link
Contributor Author

@avrhamNeeman I have updated the PR, you can re-review and let me know if there are any further changes you would like me to make.

@avrhamNeeman
Copy link
Contributor

@akarsh-jain-790 Looks good! Thanks!

@avrhamNeeman avrhamNeeman merged commit 0bd24e7 into superstreamlabs:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avrhamNeeman avrhamNeeman Awaiting requested review from avrhamNeeman avrhamNeeman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Long named tags are getting cut in station view
3 participants
@akarsh-jain-790 @yanivbh1 @avrhamNeeman