test: fix mfa tests (#805)

supertokens · Mar 16, 2024 · f28cd4c · f28cd4c
1 parent 9e0916d
commit f28cd4c
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 6 deletions.
diff --git a/test/end-to-end/mfa.chooserscreen.test.js b/test/end-to-end/mfa.chooserscreen.test.js
@@ -87,9 +87,10 @@ describe("SuperTokens SignIn w/ MFA", function () {
     });
 
     after(async function () {
-        if (!skipped) {
-            await browser.close();
+        if (skipped) {
+            return;
         }
+        await browser.close();
 
         await fetch(`${TEST_SERVER_BASE_URL}/after`, {
             method: "POST",

diff --git a/test/end-to-end/mfa.factorscreen.otp.test.js b/test/end-to-end/mfa.factorscreen.otp.test.js
@@ -88,6 +88,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
     });
 
     after(async function () {
+        if (skipped) {
+            return;
+        }
         await browser.close();
 
         await fetch(`${TEST_SERVER_BASE_URL}/after`, {

diff --git a/test/end-to-end/mfa.factorscreen.totp.test.js b/test/end-to-end/mfa.factorscreen.totp.test.js
@@ -89,8 +89,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
 
     after(async function () {
         if (skipped) {
-            await browser.close();
+            return;
         }
+        await browser.close();
 
         await fetch(`${TEST_SERVER_BASE_URL}/after`, {
             method: "POST",

diff --git a/test/end-to-end/mfa.requirement_handling.test.js b/test/end-to-end/mfa.requirement_handling.test.js
@@ -31,6 +31,7 @@ import {
     waitFor,
     getFactorChooserOptions,
     setAccountLinkingConfig,
+    isMFASupported,
 } from "../helpers";
 import fetch from "isomorphic-fetch";
 import { CREATE_CODE_API, CREATE_TOTP_DEVICE_API, MFA_INFO_API } from "../constants";
@@ -64,8 +65,14 @@ describe("SuperTokens SignIn w/ MFA", function () {
     let browser;
     let page;
     let consoleLogs = [];
+    let skipped;
 
     before(async function () {
+        if (!(await isMFASupported())) {
+            skipped = true;
+            this.skip();
+            return;
+        }
         await backendBeforeEach();
 
         await fetch(`${TEST_SERVER_BASE_URL}/startst`, {
@@ -79,6 +86,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
     });
 
     after(async function () {
+        if (skipped) {
+            return;
+        }
         await browser.close();
 
         await fetch(`${TEST_SERVER_BASE_URL}/after`, {

diff --git a/test/server/package-lock.json b/test/server/package-lock.json