Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how form fields are done #638

Open
11 tasks
rishabhpoddar opened this issue Jan 2, 2023 · 3 comments
Open
11 tasks

Change how form fields are done #638

rishabhpoddar opened this issue Jan 2, 2023 · 3 comments

Comments

@rishabhpoddar
Copy link
Member

rishabhpoddar commented Jan 2, 2023

@rishabhpoddar
Copy link
Member Author

We have this old issue (in my sprint sheet) with the login forms in auth react where if you use CSS to change the order in which input fields are rendered in the login form, pressing TAB to go to the next form field would not always work correctly. This is because using CSS to change the order of the fields only affects the final render and not the element tree itself, and the browser uses the element tree when navigating between items with TAB.
For example if the element tree looks like this:

  • Element 1 (CSS order 1)
  • Element 2 (CSS order 3)
  • Element 3 (CSS order 2)
    When tabbing from element 1, the browser will highlight element 2 even though on the UI the user would expect it to go to element 3.
    Since we are refactoring things in the form fields we may also want to look into this and see if we can make it easier for users to order the form elements.

15:39
This might have already been fixed, but just putting it out there

@ptdatta
Copy link

ptdatta commented Apr 30, 2024

Hey @rishabhpoddar are all of them fixed?

@rishabhpoddar
Copy link
Member Author

I dont think so @ptdatta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants