Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autocomplete attributes on passwordless form fields #747

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

porcellus
Copy link
Collaborator

Summary of change

add autocomplete attributes to passwordless form fields

Related issues

Test Plan

Manual testing

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

size-limit report 📦

Path Size
lib/build/index.js 14.18 KB (0%)
recipe/session/index.js 15.14 KB (0%)
recipe/session/prebuiltui.js 17.76 KB (0%)
recipe/thirdpartyemailpassword/index.js 29.65 KB (0%)
recipe/thirdparty/index.js 26.43 KB (0%)
recipe/emailpassword/index.js 9.94 KB (0%)
recipe/emailverification/index.js 7.26 KB (0%)
recipe/passwordless/index.js 63.47 KB (0%)
recipe/thirdpartypasswordless/index.js 84.2 KB (0%)
recipe/emailverification/prebuiltui.js 22.45 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 53.79 KB (0%)
recipe/thirdparty/prebuiltui.js 38.5 KB (0%)
recipe/emailpassword/prebuiltui.js 27.51 KB (0%)
recipe/passwordless/prebuiltui.js 102.78 KB (+0.03% 🔺)
recipe/thirdpartypasswordless/prebuiltui.js 130.4 KB (+0.02% 🔺)
recipe/multitenancy/index.js 6.12 KB (0%)

@rishabhpoddar rishabhpoddar merged commit efef688 into 0.35 Oct 6, 2023
3 of 6 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/add_autocomplete_pwless_forms branch October 6, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants