Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update for new node version #750

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

porcellus
Copy link
Collaborator

Summary of change

Updated test expectations to match fix in the node behaviour of the emailVerifyGET endpoint

Related issues

Test Plan

Test only change

Documentation changes

Test only change

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

@rishabhpoddar rishabhpoddar merged commit 792499c into 0.35 Oct 16, 2023
15 of 18 checks passed
@rishabhpoddar rishabhpoddar deleted the test/update_for_new_node_version branch October 16, 2023 12:22
@github-actions
Copy link

size-limit report 📦

Path Size
lib/build/index.js 14.19 KB (0%)
recipe/session/index.js 15.15 KB (0%)
recipe/session/prebuiltui.js 17.77 KB (0%)
recipe/thirdpartyemailpassword/index.js 29.65 KB (0%)
recipe/thirdparty/index.js 26.43 KB (0%)
recipe/emailpassword/index.js 9.94 KB (0%)
recipe/emailverification/index.js 7.26 KB (0%)
recipe/passwordless/index.js 63.47 KB (0%)
recipe/thirdpartypasswordless/index.js 84.2 KB (0%)
recipe/emailverification/prebuiltui.js 22.46 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 53.8 KB (0%)
recipe/thirdparty/prebuiltui.js 38.51 KB (0%)
recipe/emailpassword/prebuiltui.js 27.52 KB (0%)
recipe/passwordless/prebuiltui.js 102.79 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 130.42 KB (0%)
recipe/multitenancy/index.js 6.12 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants