Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dateProvider config #784

Merged
merged 7 commits into from
Jan 29, 2024
Merged

feat: add dateProvider config #784

merged 7 commits into from
Jan 29, 2024

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Jan 15, 2024

Summary of change

This PR adds dateProvider as a config that is used to fix clock skew issues between server and client.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

@anku255 anku255 changed the base branch from master to 0.36 January 15, 2024 07:02
@anku255 anku255 changed the title Add dateProvider config feat: add dateProvider config Jan 15, 2024
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please confirm that this fails if we are running with an old st-website version
  • Please check that all tests pass using the new version.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rishabhpoddar rishabhpoddar changed the base branch from 0.36 to 0.37 January 29, 2024 08:44
Copy link

size-limit report 📦

Path Size
lib/build/index.js 14.49 KB (+0.01% 🔺)
recipe/session/index.js 15.41 KB (+0.01% 🔺)
recipe/session/prebuiltui.js 18.17 KB (0%)
recipe/thirdpartyemailpassword/index.js 30.21 KB (0%)
recipe/thirdparty/index.js 26.82 KB (0%)
recipe/emailpassword/index.js 10.26 KB (-0.01% 🔽)
recipe/emailverification/index.js 7.5 KB (0%)
recipe/passwordless/index.js 63.93 KB (0%)
recipe/thirdpartypasswordless/index.js 83.96 KB (0%)
recipe/emailverification/prebuiltui.js 22.86 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 54.43 KB (+0.01% 🔺)
recipe/thirdparty/prebuiltui.js 38.92 KB (0%)
recipe/emailpassword/prebuiltui.js 28.19 KB (0%)
recipe/passwordless/prebuiltui.js 103.04 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 130.22 KB (-0.01% 🔽)
recipe/multitenancy/index.js 6.31 KB (0%)

@rishabhpoddar rishabhpoddar merged commit b00afa2 into 0.37 Jan 29, 2024
22 of 23 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/add-date-provider branch January 29, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants