Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: example tests #799

Merged
merged 9 commits into from
Mar 14, 2024
Merged

fix: example tests #799

merged 9 commits into from
Mar 14, 2024

Conversation

porcellus
Copy link
Collaborator

@porcellus porcellus commented Mar 13, 2024

Summary of change

Renamed validatorId to id
Small bugfixes/cleanup
Fixing example tests

Related issues

Test Plan

Updated tests should cover it

Documentation changes

Discussed on slack

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

@porcellus porcellus changed the base branch from master to 0.39 March 13, 2024 17:37
@porcellus porcellus changed the title Chore/update versions fix: example tests Mar 13, 2024
Copy link

size-limit report 📦

Path Size
lib/build/index.js 17.32 KB (-0.03% 🔽)
recipe/session/index.js 18.31 KB (-0.03% 🔽)
recipe/session/prebuiltui.js 21.12 KB (-0.03% 🔽)
recipe/thirdpartyemailpassword/index.js 30.9 KB (-0.02% 🔽)
recipe/thirdparty/index.js 27.29 KB (-0.02% 🔽)
recipe/emailpassword/index.js 10.72 KB (-0.04% 🔽)
recipe/emailverification/index.js 7.71 KB (0%)
recipe/passwordless/index.js 68.92 KB (-0.01% 🔽)
recipe/thirdpartypasswordless/index.js 89.8 KB (-0.01% 🔽)
recipe/emailverification/prebuiltui.js 27 KB (-0.02% 🔽)
recipe/thirdpartyemailpassword/prebuiltui.js 62.02 KB (-0.03% 🔽)
recipe/thirdparty/prebuiltui.js 43.58 KB (-0.03% 🔽)
recipe/emailpassword/prebuiltui.js 32.92 KB (-0.03% 🔽)
recipe/passwordless/prebuiltui.js 116.14 KB (-0.01% 🔽)
recipe/thirdpartypasswordless/prebuiltui.js 145.02 KB (-0.86% 🔽)
recipe/multitenancy/index.js 6.54 KB (0%)
recipe/multifactorauth/index.js 10.47 KB (-0.04% 🔽)
recipe/multifactorauth/prebuiltui.js 26.39 KB (-0.02% 🔽)

@rishabhpoddar rishabhpoddar merged commit 640a53d into 0.39 Mar 14, 2024
20 of 26 checks passed
@rishabhpoddar rishabhpoddar deleted the chore/update_versions branch March 14, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants