Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for how component is calculated #810

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

rishabhpoddar
Copy link
Member

Summary of change

getMatchingComponentForRouteAndRecipeIdFromPreBuiltUIList did not correctly fetch the components for non auth recipe. So that has been fixed.

Test Plan

Without this change, the way to reproduce the issue was to:

  • Enable dynamic login method
  • first factor is set to email password in tenant
  • second factor is set to otp-email
  • Load the tenant, login into first factor, and then see that the second factor screen keeps redirecting to auth

NOTE: This PR has not implemented any test case

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Copy link

size-limit report 📦

Path Size
lib/build/index.js 17.39 KB (+0.39% 🔺)
recipe/session/index.js 18.39 KB (+0.43% 🔺)
recipe/session/prebuiltui.js 21.18 KB (+0.3% 🔺)
recipe/thirdpartyemailpassword/index.js 30.9 KB (0%)
recipe/thirdparty/index.js 27.29 KB (0%)
recipe/emailpassword/index.js 10.72 KB (0%)
recipe/emailverification/index.js 7.71 KB (0%)
recipe/passwordless/index.js 68.92 KB (0%)
recipe/thirdpartypasswordless/index.js 89.8 KB (0%)
recipe/emailverification/prebuiltui.js 27.08 KB (+0.28% 🔺)
recipe/thirdpartyemailpassword/prebuiltui.js 62.23 KB (+0.13% 🔺)
recipe/thirdparty/prebuiltui.js 43.71 KB (+0.18% 🔺)
recipe/emailpassword/prebuiltui.js 33.01 KB (+0.26% 🔺)
recipe/passwordless/prebuiltui.js 116.36 KB (+0.09% 🔺)
recipe/thirdpartypasswordless/prebuiltui.js 146.6 KB (+0.06% 🔺)
recipe/multitenancy/index.js 6.54 KB (0%)
recipe/multifactorauth/index.js 10.47 KB (0%)
recipe/multifactorauth/prebuiltui.js 26.52 KB (+0.5% 🔺)

@rishabhpoddar rishabhpoddar merged commit 0cad636 into 0.39 Mar 27, 2024
24 of 26 checks passed
@rishabhpoddar rishabhpoddar deleted the fix-to-routing-component-logic branch March 27, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant