Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix import errors in e2e tests #814

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

porcellus
Copy link
Collaborator

Summary of change

Fix import errors introduced by #813 (vscode moved and supposedly updated imports but it didn't actually happen)

Related issues

Test Plan

N/A test only change

Documentation changes

N/A test only change

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

Copy link

size-limit report 📦

Path Size
lib/build/index.js 17.67 KB (0%)
recipe/session/index.js 18.69 KB (0%)
recipe/session/prebuiltui.js 21.5 KB (0%)
recipe/thirdpartyemailpassword/index.js 31.11 KB (0%)
recipe/thirdparty/index.js 27.5 KB (0%)
recipe/emailpassword/index.js 10.89 KB (0%)
recipe/emailverification/index.js 7.71 KB (0%)
recipe/passwordless/index.js 69.08 KB (0%)
recipe/thirdpartypasswordless/index.js 89.99 KB (0%)
recipe/emailverification/prebuiltui.js 27.43 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 62.56 KB (0%)
recipe/thirdparty/prebuiltui.js 44.02 KB (0%)
recipe/emailpassword/prebuiltui.js 33.32 KB (0%)
recipe/passwordless/prebuiltui.js 116.74 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 146.95 KB (0%)
recipe/multitenancy/index.js 6.54 KB (0%)
recipe/multifactorauth/index.js 10.63 KB (0%)
recipe/multifactorauth/prebuiltui.js 26.84 KB (0%)

@rishabhpoddar rishabhpoddar merged commit cc77529 into 0.40 Apr 16, 2024
23 of 26 checks passed
@rishabhpoddar rishabhpoddar deleted the test/fix_e2e_import_errors branch April 16, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants